Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning, packaging and continuous deployment on PyPI #105

Merged
merged 25 commits into from
Mar 12, 2021

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Feb 17, 2021

  • Merge PR Prepare first upload to PyPI #107
  • Merge PR Update DOIs after latest release #109
  • make sure versioning works correctly
  • make sure CD works correctly (tested from branch test_maintenance-versioning, since this cannot be performed from a PR - GitHub secrets are not passed from forks)
  • make sure pip package for released version is installed correctly from PyPI
  • check development installation
    • tests
    • update docs

@HealthyPear HealthyPear added this to the v0.5.0 milestone Feb 17, 2021
@HealthyPear HealthyPear added this to In progress in Maintenance via automation Feb 17, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HealthyPear HealthyPear linked an issue Feb 17, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #105 (16e0177) into master (ee76a29) will increase coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   39.00%   39.23%   +0.23%     
==========================================
  Files          20       22       +2     
  Lines        1841     1858      +17     
==========================================
+ Hits          718      729      +11     
- Misses       1123     1129       +6     
Impacted Files Coverage Δ
protopipe/version.py 54.54% <54.54%> (ø)
protopipe/_dev_version.py 80.00% <80.00%> (ø)
protopipe/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee76a29...16e0177. Read the comment docs.

@HealthyPear HealthyPear marked this pull request as ready for review March 8, 2021 10:30
@HealthyPear HealthyPear requested a review from kosack March 8, 2021 10:30
@HealthyPear HealthyPear requested review from kosack and removed request for kosack March 10, 2021 14:03
Maintenance automation moved this from In progress to Reviewer approved Mar 12, 2021
@HealthyPear HealthyPear merged commit e4e7114 into cta-observatory:master Mar 12, 2021
Maintenance automation moved this from Reviewer approved to Done Mar 12, 2021
@HealthyPear HealthyPear deleted the maintenance-versioning branch March 12, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

Packaging maintenance
2 participants