Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TRAINING integration tests #111

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Mar 9, 2021

In this PR

  • Use Prod3b test files
  • Use get_dataset_path from latest ctapipe to be already set up for use of the cc-in2p3 dataserver

other things to do (ctapipe extra resources)

so we would be able to

  • test on diffuse data only
  • test already on prod5

what we should add more

  • add the possibility to test on multiple files
  • add a very simple check on HDF5 output file (e.g. non-empty should be sufficient)

@HealthyPear HealthyPear added this to the v0.5.0 milestone Mar 9, 2021
@HealthyPear HealthyPear added this to In progress in Maintenance via automation Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #111 (d864ddd) into master (99c7e81) will increase coverage by 1.93%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   37.06%   39.00%   +1.93%     
==========================================
  Files          20       20              
  Lines        1802     1841      +39     
==========================================
+ Hits          668      718      +50     
+ Misses       1134     1123      -11     
Impacted Files Coverage Δ
protopipe/pipeline/temp.py 74.46% <56.00%> (-6.70%) ⬇️
protopipe/scripts/tests/test_dataTraining.py 100.00% <100.00%> (ø)
protopipe/pipeline/utils.py 52.56% <0.00%> (+1.92%) ⬆️
protopipe/pipeline/event_preparer.py 76.62% <0.00%> (+7.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c7e81...d864ddd. Read the comment docs.

@HealthyPear HealthyPear marked this pull request as draft March 9, 2021 20:50
@HealthyPear HealthyPear mentioned this pull request Mar 10, 2021
14 tasks
@HealthyPear HealthyPear marked this pull request as ready for review March 10, 2021 13:21
@HealthyPear HealthyPear requested a review from kosack March 10, 2021 13:22
Maintenance automation moved this from In progress to Reviewer approved Mar 10, 2021
@HealthyPear HealthyPear merged commit ee76a29 into cta-observatory:master Mar 10, 2021
Maintenance automation moved this from Reviewer approved to Done Mar 10, 2021
@HealthyPear HealthyPear deleted the maintenance-update_TRAINING_test branch March 10, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants