Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update training integration tests #113

Conversation

HealthyPear
Copy link
Member

This PR updates the current 2 tests performed over the TRAINING tool (w/o full DL1a images) by

  • using only diffuse data
  • all test data (full-analysis test suites) can be downloaded from the CC-IN2P3 data server
  • both Pro3b baseline arrays are tested with Z=20° and Az=180°
  • ready for extending testing for prod5 as soon as test data has been added

- all test data is now on dataserver
- both prod3b baseline arrays are tested
@HealthyPear HealthyPear added this to In progress in Maintenance via automation Mar 17, 2021
@HealthyPear HealthyPear requested a review from kosack March 17, 2021 13:44
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #113 (c5be211) into master (2667706) will decrease coverage by 0.00%.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   39.23%   39.22%   -0.01%     
==========================================
  Files          22       22              
  Lines        1858     1912      +54     
==========================================
+ Hits          729      750      +21     
- Misses       1129     1162      +33     
Impacted Files Coverage Δ
protopipe/pipeline/temp.py 74.14% <74.54%> (-0.32%) ⬇️
protopipe/scripts/tests/test_dataTraining.py 100.00% <100.00%> (ø)
protopipe/pipeline/event_preparer.py 69.34% <0.00%> (-7.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2667706...c5be211. Read the comment docs.

Maintenance automation moved this from In progress to Reviewer approved Mar 19, 2021
@HealthyPear HealthyPear merged commit e708fe7 into cta-observatory:master Mar 19, 2021
Maintenance automation moved this from Reviewer approved to Done Mar 19, 2021
@HealthyPear HealthyPear deleted the maintenance_update_TRAINING_integration_test_diffuse branch March 19, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants