Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup of pipeline integration testing up to modeling #116

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Mar 25, 2021

Requirements

Description

This PR refactors integration tests in a single module called test_pipeline.py where,

  • the whole pipeline will be tested on standard settings starting from diffuse test files stored in the ccin2p3 dataserver
  • integration tests follow the pipeline workflow
  • they produce their own output files and are skipped if a previous test fails to produce the expected output
  • current tests cover training and modeling
  • all tests are performed on a CTAN and CTAS Prod3b baseline analysis using all available cameras
  • all tests share a temporary directory where all produced files have unique suffixes defined by their test case

@HealthyPear HealthyPear added this to In progress in Maintenance via automation Mar 25, 2021
@HealthyPear HealthyPear requested a review from kosack March 25, 2021 12:12
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #116 (bf85742) into master (e87557c) will increase coverage by 7.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   38.61%   46.30%   +7.69%     
==========================================
  Files          22       22              
  Lines        1950     1978      +28     
==========================================
+ Hits          753      916     +163     
+ Misses       1197     1062     -135     
Impacted Files Coverage Δ
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)
protopipe/pipeline/utils.py 54.54% <0.00%> (+3.63%) ⬆️
protopipe/pipeline/event_preparer.py 76.62% <0.00%> (+7.27%) ⬆️
protopipe/mva/utils.py 30.43% <0.00%> (+18.11%) ⬆️
protopipe/mva/train_model.py 60.78% <0.00%> (+45.09%) ⬆️
protopipe/scripts/build_model.py 61.29% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7632ef2...bf85742. Read the comment docs.

Maintenance automation moved this from In progress to Reviewer approved Mar 25, 2021
conftest.py Show resolved Hide resolved
@HealthyPear
Copy link
Member Author

@kosack did you notice PR #114 ? I can't merge this one before because I am using some of the new flag options in the model script

@HealthyPear HealthyPear merged commit 21b483c into cta-observatory:master Mar 26, 2021
Maintenance automation moved this from Reviewer approved to Done Mar 26, 2021
@HealthyPear HealthyPear deleted the maintenance-integration_test_pipeline_up_to_models branch March 26, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants