Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline integration test workflow #118

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

HealthyPear
Copy link
Member

I noticed that I forgot to use the estimated energy (both telescope-wise and event-wise )as a classification parameter as it is done currently in a standard analysis with protopipe.

@HealthyPear HealthyPear added fix A PR that fixes a bug or a wrong behaviour. maintenance labels Mar 29, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Mar 29, 2021
@HealthyPear HealthyPear added this to In progress in Maintenance via automation Mar 29, 2021
@HealthyPear HealthyPear added this to In progress in Bugs and wrong behaviours via automation Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #118 (01b3aa2) into master (21b483c) will increase coverage by 1.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   46.30%   47.32%   +1.01%     
==========================================
  Files          22       22              
  Lines        1978     1980       +2     
==========================================
+ Hits          916      937      +21     
+ Misses       1062     1043      -19     
Impacted Files Coverage Δ
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)
protopipe/pipeline/utils.py 55.75% <0.00%> (+1.21%) ⬆️
protopipe/scripts/data_training.py 94.65% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b483c...01b3aa2. Read the comment docs.

@HealthyPear HealthyPear requested a review from kosack March 29, 2021 13:25
Maintenance automation moved this from In progress to Reviewer approved Mar 29, 2021
@HealthyPear HealthyPear merged commit 6d7a41f into cta-observatory:master Mar 29, 2021
Bugs and wrong behaviours automation moved this from In progress to Closed Mar 29, 2021
Maintenance automation moved this from Reviewer approved to Done Mar 29, 2021
@HealthyPear HealthyPear deleted the fix-integration-tests branch March 29, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A PR that fixes a bug or a wrong behaviour. maintenance
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants