Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and improvements to protopipe-MODELS #122

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

HealthyPear
Copy link
Member

This PR fixes some bugs uncovered by fixing the associated integration test (PR #120)

@HealthyPear HealthyPear added wrong behaviour The code works but produces clearly wrong results fix A PR that fixes a bug or a wrong behaviour. labels Mar 30, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Mar 30, 2021
@HealthyPear HealthyPear added this to In progress in Bugs and wrong behaviours via automation Mar 30, 2021
@HealthyPear HealthyPear mentioned this pull request Mar 30, 2021
2 tasks
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #122 (9198cec) into master (0dc958c) will decrease coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   47.64%   47.61%   -0.03%     
==========================================
  Files          22       22              
  Lines        1992     1995       +3     
==========================================
+ Hits          949      950       +1     
- Misses       1043     1045       +2     
Impacted Files Coverage Δ
protopipe/mva/train_model.py 60.78% <0.00%> (ø)
protopipe/scripts/build_model.py 60.62% <25.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc958c...9198cec. Read the comment docs.

@HealthyPear HealthyPear merged commit 4c7a7fe into cta-observatory:master Mar 30, 2021
Bugs and wrong behaviours automation moved this from In progress to Closed Mar 30, 2021
@HealthyPear HealthyPear deleted the fix-build_models_mva branch March 30, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A PR that fixes a bug or a wrong behaviour. wrong behaviour The code works but produces clearly wrong results
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants