Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DL2 integration tests #126

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Apr 14, 2021

Requirements for merging

Description

Through this PR we implement a set of 3 integration tests for DL2 (1 per particle type).

Probably 1 could have been sufficient, but they are relatively fast, using about <~10 shower each.

@HealthyPear HealthyPear added this to the v0.5.0 milestone Apr 14, 2021
@HealthyPear HealthyPear added this to In progress in Maintenance via automation Apr 14, 2021
@HealthyPear HealthyPear requested a review from kosack April 14, 2021 18:20
@HealthyPear HealthyPear mentioned this pull request Apr 14, 2021
14 tasks
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #126 (9f1427f) into master (61722f9) will increase coverage by 11.37%.
The diff coverage is 100.00%.

❗ Current head 9f1427f differs from pull request most recent head 294b850. Consider uploading reports for the commit 294b850 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #126       +/-   ##
===========================================
+ Coverage   48.93%   60.30%   +11.37%     
===========================================
  Files          23       23               
  Lines        2058     2091       +33     
===========================================
+ Hits         1007     1261      +254     
+ Misses       1051      830      -221     
Impacted Files Coverage Δ
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)
protopipe/scripts/write_dl2.py 82.45% <0.00%> (+77.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61722f9...294b850. Read the comment docs.

Maintenance automation moved this from In progress to Reviewer approved Apr 19, 2021
@HealthyPear HealthyPear merged commit 9149e12 into cta-observatory:master Apr 19, 2021
Maintenance automation moved this from Reviewer approved to Done Apr 19, 2021
@HealthyPear HealthyPear deleted the maintenance-add_DL2_integration_tests branch April 19, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants