Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add choice of estimation weigths and standard deviation for RandomForestRegressor models #134

Conversation

HealthyPear
Copy link
Member

This PR adds the key estimation_weight in analysis.yaml for both estimators.

For the energy, the choice can be either the standard deviation from the single forest's trees or an evaluation of a DL1 basic feature like for the model building.

For the classifier, the choice is also an evaluation of basic DL1 quantities.

@HealthyPear HealthyPear added enhancement New feature or request machine learning labels May 10, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone May 10, 2021
@HealthyPear HealthyPear added this to In progress in Pipeline features and enhancements via automation May 10, 2021
@HealthyPear HealthyPear linked an issue May 10, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #134 (24c15a9) into master (ff7ea05) will decrease coverage by 0.09%.
The diff coverage is 64.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   60.46%   60.36%   -0.10%     
==========================================
  Files          23       23              
  Lines        2102     2122      +20     
==========================================
+ Hits         1271     1281      +10     
- Misses        831      841      +10     
Impacted Files Coverage Δ
protopipe/scripts/data_training.py 92.75% <54.54%> (-2.20%) ⬇️
protopipe/scripts/write_dl2.py 81.41% <71.42%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7ea05...24c15a9. Read the comment docs.

@HealthyPear HealthyPear requested a review from kosack May 10, 2021 17:00
Pipeline features and enhancements automation moved this from In progress to Reviewer approved May 10, 2021
@HealthyPear HealthyPear merged commit b1e0a9d into cta-observatory:master May 11, 2021
Pipeline features and enhancements automation moved this from Reviewer approved to Done May 11, 2021
@HealthyPear HealthyPear deleted the feature-model_weights_and_RF_error branch May 11, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request machine learning
Development

Successfully merging this pull request may close these issues.

Make weight for final energy/classification estimation configurable
2 participants