Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for DL2-to-DL3 step #137

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented May 11, 2021

This PR adds the test for the last step of the pipeline.

I had to modify (actually slightly improve) the CLI of the script in order to overwrite some of the input settings coming from the configuration file.

I also added some development code from pyirf to allow the writing of empty tables of DL3 information in case no DL2 events are selected from the analysis (it happens with the prod3b CTAN test analysis).

The integration test checks that the script doesn't crash (for any reason) and that the output file has the expected number of HDUs from the current script and that each HDU has some data in it.

@HealthyPear HealthyPear added this to the v0.5.0 milestone May 11, 2021
@HealthyPear HealthyPear added this to In progress in Maintenance via automation May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #137 (fc7212f) into master (e7825c0) will increase coverage by 5.24%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   60.35%   65.59%   +5.24%     
==========================================
  Files          23       23              
  Lines        2101     2142      +41     
==========================================
+ Hits         1268     1405     +137     
+ Misses        833      737      -96     
Impacted Files Coverage Δ
protopipe/perf/__init__.py 100.00% <ø> (ø)
protopipe/scripts/make_performance_EventDisplay.py 95.32% <70.58%> (+73.54%) ⬆️
protopipe/perf/temp.py 100.00% <100.00%> (+76.47%) ⬆️
protopipe/perf/utils.py 57.57% <100.00%> (+33.04%) ⬆️
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)
protopipe/pipeline/event_preparer.py 65.23% <0.00%> (-4.93%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7825c0...fc7212f. Read the comment docs.

@HealthyPear HealthyPear mentioned this pull request May 11, 2021
14 tasks
@HealthyPear HealthyPear requested a review from kosack May 12, 2021 08:17
kosack
kosack previously approved these changes May 12, 2021
Maintenance automation moved this from In progress to Reviewer approved May 12, 2021
Maintenance automation moved this from Reviewer approved to Review in progress May 12, 2021
@HealthyPear HealthyPear requested a review from kosack May 12, 2021 10:57
@HealthyPear HealthyPear linked an issue May 13, 2021 that may be closed by this pull request
14 tasks
Maintenance automation moved this from Review in progress to Reviewer approved May 14, 2021
@HealthyPear HealthyPear merged commit 57d344a into cta-observatory:master May 14, 2021
Maintenance automation moved this from Reviewer approved to Done May 14, 2021
@HealthyPear HealthyPear deleted the maintenance-integration_test_getDL3 branch May 14, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

Setup integration tests pipeline
2 participants