Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that estimated energy is always recorded in linear scale #141

Conversation

HealthyPear
Copy link
Member

This closes #139.

It also fixes a detail about energy estimation à-la-CTAMARS (#92), namely,

[...] the RFs provide estimates for log10 E and its RMS, but the average is done after converting those to linear energy scale)

@HealthyPear HealthyPear added the fix A PR that fixes a bug or a wrong behaviour. label May 17, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone May 17, 2021
@HealthyPear HealthyPear added this to In progress in Bugs and wrong behaviours via automation May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #141 (a819c7b) into master (fd7b693) will increase coverage by 0.36%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   65.19%   65.55%   +0.36%     
==========================================
  Files          23       23              
  Lines        2146     2160      +14     
==========================================
+ Hits         1399     1416      +17     
+ Misses        747      744       -3     
Impacted Files Coverage Δ
protopipe/scripts/build_model.py 85.36% <66.66%> (-0.96%) ⬇️
protopipe/scripts/data_training.py 92.89% <100.00%> (+0.13%) ⬆️
protopipe/scripts/write_dl2.py 81.66% <100.00%> (+0.24%) ⬆️
protopipe/perf/temp.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7b693...a819c7b. Read the comment docs.

@HealthyPear HealthyPear merged commit b1e1574 into cta-observatory:master May 19, 2021
Bugs and wrong behaviours automation moved this from In progress to Closed May 19, 2021
@HealthyPear HealthyPear deleted the fix-energy_scale_in_and_from_model branch May 19, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A PR that fixes a bug or a wrong behaviour.
Projects
Development

Successfully merging this pull request may close these issues.

Reconstructed energy is written in logscale while true energy in linear scale
2 participants