Calculate impact parameter always in the tilted frame #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HealthyPear
added
enhancement
HealthyPear
added this to In progress
in Pipeline features and enhancements
via automation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 65.55% 65.61% +0.06%
==========================================
Files 23 23
Lines 2160 2164 +4
==========================================
+ Hits 1416 1420 +4
Misses 744 744
Continue to review full report at Codecov.
|
Pipeline features and enhancements
automation
moved this from In progress
to Reviewer approved
May 20, 2021
kosack
approved these changes
May 20, 2021
Pipeline features and enhancements
automation
moved this from Reviewer approved
to Done
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this PR I basically bring the estimated core position back to the tilted frame (in which it was before being recorded by the HillasReconstructor)