Apply CALIB_SCALE directly from ctapipe.io.SimtelEventSource #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified version of SimtelEventSource
HealthyPear
added this to In progress
in Pipeline features and enhancements
via automation
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 65.69% 66.93% +1.23%
==========================================
Files 23 23
Lines 2169 2238 +69
==========================================
+ Hits 1425 1498 +73
+ Misses 744 740 -4
Continue to review full report at Codecov.
|
HealthyPear
changed the title
kosack
reviewed
Jun 16, 2021
Pipeline features and enhancements
automation
moved this from In progress
to Review in progress
Jul 7, 2021
kosack
requested changes
Jul 7, 2021
kosack
previously approved these changes
Jul 7, 2021
Pipeline features and enhancements
automation
moved this from Review in progress
to Reviewer approved
Jul 7, 2021
Pipeline features and enhancements
automation
moved this from Reviewer approved
to Review in progress
Jul 7, 2021
Pipeline features and enhancements
automation
moved this from Review in progress
to Reviewer approved
Jul 7, 2021
kosack
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically implements what is currently pending in cta-observatory/ctapipe#1749