Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Closes #15 #16

Merged
merged 1 commit into from Oct 28, 2019
Merged

Conversation

HealthyPear
Copy link
Member

In Issue #15 it has been reported that the new ctapipe-based cleaning for the biggest cluster (or island) was crashing in case of no islands surviving the cleaning algorithm.

This has been now fixed by checking beforehand the number of surviving islands and calling the function largest island only in case of more than 1 island left in the image.
In the case of only 1 island left, the cleaning mask is the original one.
In the case of no islands, the original (empty) cleaned image is used.
A similar check is applied in the case of extended cleaning, which would take into account all the surviving islands but which for the moment is set to be the same as the biggest cleaning.

The new code has been tested successfully on 500 events from file gamma_20deg_180deg_run100___cta-prod3-demo-2147m-LaPalma-baseline.simtel.gz using both DL1 and DL2 scripts (the latter without model estimation, so the result is the same as for DL1):

EventCutFlow
   Cut Name   selected Events Efficiency
------------- --------------- ----------
       noCuts             500      1.000
min2Tels trig             500      1.000
min2Tels reco             349      0.698
direction nan             349      0.698

ImageCutFlow
     Cut Name     selected Events Efficiency
----------------- --------------- ----------
           noCuts            2313      1.000
        min pixel            2157      0.933
       min charge            2119      0.916
     poor moments            2119      0.916
  bad ellipticity            1578      0.682
close to the edge            1966      0.850

After this PR the new bugfix version 0.2.1 will be released.

@HealthyPear HealthyPear merged commit 530e45b into cta-observatory:master Oct 28, 2019
@HealthyPear HealthyPear deleted the bugfix-issue15 branch October 28, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants