Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve protopipe.mva and protopipe-MODELS #164

Merged
merged 22 commits into from
Feb 11, 2022

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Sep 29, 2021

Description

  • allows for full training scenario, i.e. the whole input dataset is used for training and there is no exported test data (aka the test sample is the one used in the next step of the pipeline and thus the benchmarking will be possible only at that stage)
  • improved usage of GridSearchCV algorithm for model cross-validation (exhaustive grid search along hyper-parameter space)
  • update of model-related configuration files (and their test version)
  • small fixes

@HealthyPear HealthyPear added enhancement New feature or request machine learning labels Sep 29, 2021
@HealthyPear HealthyPear added this to the v0.5.0 milestone Sep 29, 2021
@HealthyPear HealthyPear added this to In progress in Pipeline features and enhancements via automation Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #164 (8057ba5) into master (4f66db8) will decrease coverage by 0.53%.
The diff coverage is 62.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   67.19%   66.65%   -0.54%     
==========================================
  Files          24       24              
  Lines        2545     2600      +55     
==========================================
+ Hits         1710     1733      +23     
- Misses        835      867      +32     
Impacted Files Coverage Δ
protopipe/mva/train_model.py 54.68% <36.36%> (-9.32%) ⬇️
protopipe/scripts/write_dl2.py 80.67% <50.00%> (-0.44%) ⬇️
protopipe/pipeline/io.py 47.27% <57.69%> (+23.93%) ⬆️
protopipe/mva/utils.py 29.07% <63.63%> (-1.58%) ⬇️
protopipe/scripts/build_model.py 84.61% <80.00%> (-0.76%) ⬇️
protopipe/mva/io.py 100.00% <100.00%> (ø)
protopipe/scripts/model_diagnostic.py 7.21% <100.00%> (+0.44%) ⬆️
protopipe/pipeline/utils.py 46.34% <0.00%> (-2.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f66db8...8057ba5. Read the comment docs.

@HealthyPear HealthyPear marked this pull request as ready for review January 24, 2022 18:52
@HealthyPear HealthyPear marked this pull request as draft February 1, 2022 12:12
@HealthyPear HealthyPear marked this pull request as ready for review February 1, 2022 14:35
Pipeline features and enhancements automation moved this from In progress to Reviewer approved Feb 11, 2022
@HealthyPear HealthyPear merged commit 3c9a692 into master Feb 11, 2022
Pipeline features and enhancements automation moved this from Reviewer approved to Done Feb 11, 2022
@HealthyPear HealthyPear deleted the improve_mva_and_build_models branch February 11, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request machine learning
Development

Successfully merging this pull request may close these issues.

None yet

2 participants