Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks for low-level benchmarking #42

Merged

Conversation

HealthyPear
Copy link
Member

Description:

These are the notebooks that I developed in the framework of the protopipe-CTA/MARS comparison.
For the moment the structure is the following,

  • DL1
    -- calibration
    -- image cleaning
  • DL2
  • DL3

As you probably guessed, this is similar to the one described here for the simple reason that I plan to export it once I am satisfied.

Meanwhile, this will make it easier for others to:

  • crosscheck what I am doing in light of what I upload(ed) here
  • adding new plots/benchmarks (I recall that there is already a reference we can use as a steering document)
  • lay the ground for the future export to cta-benchmark / ctaplot

Caveats:

  • currently dependent on the data format currently used by protopipe
  • mono-telescope images are not taken into account in the official code, but I am using them in my tests (the changes are too big and aleatory at the moment to make a PR); this will be automatic with the new DL1 script.
  • not completed; in particular I am working on image_cleaning so expect changes there (the material already present in calibration should be fine)

@HealthyPear HealthyPear added the enhancement New feature or request label Feb 3, 2020
@HealthyPear HealthyPear added this to the Release 0.3 milestone Feb 3, 2020
@HealthyPear HealthyPear added this to In progress in Pipeline features and enhancements via automation Feb 3, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #42   +/-   ##
======================================
  Coverage    0.43%   0.43%           
======================================
  Files          20      20           
  Lines        2084    2084           
======================================
  Hits            9       9           
  Misses       2075    2075

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5566a49...35f0c89. Read the comment docs.

Pipeline features and enhancements automation moved this from In progress to Reviewer approved Feb 5, 2020
@HealthyPear HealthyPear merged commit c2be3b2 into cta-observatory:master Feb 5, 2020
Pipeline features and enhancements automation moved this from Reviewer approved to Done Feb 5, 2020
@HealthyPear HealthyPear deleted the feature-add_notebooks branch February 5, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants