Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on notebooks #47

Conversation

HealthyPear
Copy link
Member

Description:

Relevant issues are #24 and #37 .

  • Added new notebook for direction reconstruction,
  • Moved there section about Direction Look-up tables from the image cleaning notebook,
  • Updated plots in image cleaning

Caveats:

  • image cleaning section missing 1 plot from initial comparison
  • direction reconstruction notebook is in DL1 folder because in current protopipe that information is in DL1 file
  • contrary to the calibration notebook, these two are still a WIP

@HealthyPear HealthyPear added the enhancement New feature or request label Feb 25, 2020
@HealthyPear HealthyPear added this to the Release 0.3 milestone Feb 25, 2020
@HealthyPear HealthyPear added this to In progress in Pipeline features and enhancements via automation Feb 25, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #47   +/-   ##
======================================
  Coverage    0.43%   0.43%           
======================================
  Files          20      20           
  Lines        2084    2084           
======================================
  Hits            9       9           
  Misses       2075    2075

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2be3b2...17d3fe1. Read the comment docs.

Pipeline features and enhancements automation moved this from In progress to Reviewer approved Mar 31, 2020
@HealthyPear HealthyPear merged commit d928c4c into cta-observatory:master Apr 6, 2020
Pipeline features and enhancements automation moved this from Reviewer approved to Done Apr 6, 2020
@HealthyPear HealthyPear deleted the feature-image_cleaning_notebook branch April 6, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants