Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert pointing values to float64 at reading time #68

Merged
merged 2 commits into from Oct 23, 2020
Merged

Convert pointing values to float64 at reading time #68

merged 2 commits into from Oct 23, 2020

Conversation

HealthyPear
Copy link
Member

@HealthyPear HealthyPear commented Oct 23, 2020 •
edited

Fixes #64

@HealthyPear HealthyPear added the fix A PR that fixes a bug or a wrong behaviour. label Oct 23, 2020
@HealthyPear HealthyPear added this to the 0.2.2 milestone Oct 23, 2020
@HealthyPear HealthyPear added this to In progress in Bugs and wrong behaviours via automation Oct 23, 2020
@HealthyPear HealthyPear changed the title Convert pointing values to float64 at reading time (Fixes #64) Convert pointing values to float64 at reading time Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020 •
edited

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #68   +/-   ##
======================================
  Coverage    0.39%   0.39%           
======================================
  Files          20      20           
  Lines        2268    2268           
======================================
  Hits            9       9           
  Misses       2259    2259
Impacted Files Coverage Δ
protopipe/pipeline/event_preparer.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038e733...ee0bc51. Read the comment docs.

@HealthyPear HealthyPear merged commit 1c8da28 into cta-observatory:master Oct 23, 2020
Bugs and wrong behaviours automation moved this from In progress to Closed Oct 23, 2020
@HealthyPear HealthyPear deleted the fix-issue64 branch October 23, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosack kosack kosack approved these changes

Assignees
No one assigned
Labels
fix A PR that fixes a bug or a wrong behaviour.
Projects
Bugs and wrong behaviours
  
Closed
Milestone
Release 0.3
Development

Successfully merging this pull request may close these issues.

TypeError due to astropy
2 participants
@HealthyPear @kosack