pycorsikaio to astropy Qtable #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reader base class - CorsikaReader class
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
===========================================
- Coverage 95.99% 80.29% -15.70%
===========================================
Files 20 22 +2
Lines 474 736 +262
===========================================
+ Hits 455 591 +136
- Misses 19 145 +126
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first proposal to add a new reader based on astropy.
The main features are the same as in #14, but with units from #23.
At the time I didn't test it with the latest release of pycorsikaio, so there are some limitations that should probably be addressed:
Generally, I think the quality of the code could be improved a lot since I never showed it before.
Also, the reader can read data blocks in a modular way, but will always try to join the tables. When I was developing the same reader for the XCDF data format I noticed that some showers produced so many events (in the detector) that the table joining was failing due to memory limitations. In that reader, I also added a
get_tables()method to return all tables separately without joining (likeshower_events, water_hits, photoelectrons = hawcsim_reader.get_tables()) - perhaps it can be useful also here.Closes #14