-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a unit to all fields #23
Conversation
- Added unit to Field - Set default unit to None - Added build_data_dtype
Codecov ReportBase: 96.19% // Head: 95.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 96.19% 95.79% -0.40%
==========================================
Files 19 20 +1
Lines 394 452 +58
==========================================
+ Hits 379 433 +54
- Misses 15 19 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
af9ac44
to
d0c8247
Compare
4f8a30c
to
3cf4cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise a very nice addition, thanks!
6fee32a
to
15b0367
Compare
- fix syntax error in subblocks import __all__ - differentiate version warning between dtypes and fields - unify build_data_dtype with build_dtype Do not expose dimensionless units Update unit-tests Set itemsize to None in datablocks + fix comment Fix Gev to GeV everywhere Fix syntax when asserting against None
77c08f4
to
274371e
Compare
This PR adds a unit to all fields, in particular
This is both useful by itself and a precursor for #14.