Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astropy to 4.0.2 to fix fits 1d issue #102

Merged
merged 3 commits into from Oct 12, 2020
Merged

Update astropy to 4.0.2 to fix fits 1d issue #102

merged 3 commits into from Oct 12, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 12, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #102 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   89.20%   89.18%   -0.02%     
==========================================
  Files          36       36              
  Lines        1195     1193       -2     
==========================================
- Hits         1066     1064       -2     
  Misses        129      129              
Impacted Files Coverage Δ
pyirf/tests/test_eventdisplay_comparison.py 100.00% <100.00%> (ø)
pyirf/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5e83f...a518a54. Read the comment docs.

Copy link
Member

@HealthyPear HealthyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove any related material from the code, e.g. in the integration test we have code checking the rows dimentionality in the HDUs that will become stale with these changes.

setup.py Show resolved Hide resolved
@maxnoe
Copy link
Member Author

maxnoe commented Oct 12, 2020

Ok, I removed the "ignored_errors" part in the integration test as these are now expected to pass and they do

@maxnoe maxnoe merged commit 0159bfe into master Oct 12, 2020
@maxnoe maxnoe deleted the update_astropy branch October 12, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants