Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counts / weighted counts per particle type #108

Merged
merged 5 commits into from Nov 4, 2020
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 30, 2020

adds n_{electron/proton}{,_weighted} in the sensitivity table (Results look ok)

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #108 into master will increase coverage by 0.18%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   89.25%   89.44%   +0.18%     
==========================================
  Files          36       36              
  Lines        1201     1241      +40     
==========================================
+ Hits         1072     1110      +38     
- Misses        129      131       +2     
Impacted Files Coverage Δ
pyirf/sensitivity.py 90.76% <75.00%> (-1.30%) ⬇️
pyirf/binning.py 97.10% <90.00%> (-1.21%) ⬇️
pyirf/tests/test_binning.py 100.00% <100.00%> (ø)
pyirf/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f29bd...256a033. Read the comment docs.

@maxnoe maxnoe merged commit 9212439 into master Nov 4, 2020
@maxnoe maxnoe deleted the add_particle_types branch November 4, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants