Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of general cut optimizations #123

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Feb 10, 2021

  • tests
  • docs
  • Option to parallelize, since it takes rather long for fine binning

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #123 (64cca6f) into master (154ad75) will decrease coverage by 3.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   86.95%   83.73%   -3.23%     
==========================================
  Files          35       35              
  Lines        1273     1322      +49     
==========================================
  Hits         1107     1107              
- Misses        166      215      +49     
Impacted Files Coverage Δ
pyirf/cut_optimization.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154ad75...64cca6f. Read the comment docs.

@maxnoe maxnoe marked this pull request as draft February 10, 2021 09:14
@HealthyPear HealthyPear added the enhancement New feature or request label Apr 9, 2021
@HealthyPear HealthyPear added this to In progress in Next release via automation Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Next release
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants