Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gammapy conversion for IRFs #135

Merged
merged 9 commits into from Mar 19, 2021
Merged

Gammapy conversion for IRFs #135

merged 9 commits into from Mar 19, 2021

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Mar 18, 2021

No description provided.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #135 (e0d9027) into master (154ad75) will increase coverage by 0.39%.
The diff coverage is 96.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   86.95%   87.35%   +0.39%     
==========================================
  Files          35       38       +3     
  Lines        1273     1329      +56     
==========================================
+ Hits         1107     1161      +54     
- Misses        166      168       +2     
Impacted Files Coverage Δ
pyirf/io/gadf.py 100.00% <ø> (ø)
pyirf/gammapy.py 92.85% <92.85%> (ø)
pyirf/tests/test_gammapy_interop.py 100.00% <100.00%> (ø)
pyirf/version.py 100.00% <100.00%> (ø)
pyirf/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154ad75...e0d9027. Read the comment docs.

@maxnoe maxnoe changed the title Gammapy conversion for effective area Gammapy conversion for IRFs Mar 18, 2021
@maxnoe maxnoe mentioned this pull request Mar 18, 2021
setup.py Show resolved Hide resolved
pyirf/io/gadf.py Show resolved Hide resolved
pyirf/tests/test_gammapy_interop.py Show resolved Hide resolved
docs/gammapy.rst Show resolved Hide resolved
@maxnoe maxnoe merged commit 27f2a05 into master Mar 19, 2021
@maxnoe maxnoe deleted the gammapy_conversions branch March 19, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide functions to directly convert pyirf in-memory representation to gammapy IRF classes
2 participants