Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include endpoint in create_bins_per_decade if it matches the regular spacing, fixes #187 #188

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #188 (9b73191) into master (285bca1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   90.73%   90.77%   +0.04%     
==========================================
  Files          41       41              
  Lines        1598     1605       +7     
==========================================
+ Hits         1450     1457       +7     
  Misses        148      148              
Impacted Files Coverage Δ
pyirf/binning.py 96.29% <100.00%> (+0.09%) ⬆️
pyirf/tests/test_binning.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285bca1...9b73191. Read the comment docs.

Copy link

@SeiyaNozaki SeiyaNozaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks fine!

@maxnoe maxnoe merged commit c44f1e7 into master Jul 18, 2022
@maxnoe maxnoe deleted the endpoint branch July 18, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants