Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore under/overflow events in table operations #189

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 20, 2022

evaluate_binned_cut, angular_resolution and energy_bias_resolution were creating exceptions on events outside the specified bins.

Reported by @FrancaCassol

@maxnoe maxnoe requested a review from HealthyPear as a code owner July 20, 2022 09:46
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #189 (cb09ddb) into master (45a7416) will increase coverage by 0.55%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   90.73%   91.29%   +0.55%     
==========================================
  Files          41       41              
  Lines        1598     1689      +91     
==========================================
+ Hits         1450     1542      +92     
+ Misses        148      147       -1     
Impacted Files Coverage Δ
pyirf/binning.py 98.29% <80.00%> (+2.08%) ⬆️
pyirf/benchmarks/angular_resolution.py 100.00% <100.00%> (ø)
pyirf/benchmarks/energy_bias_resolution.py 75.55% <100.00%> (+0.55%) ⬆️
pyirf/cuts.py 94.64% <100.00%> (+0.30%) ⬆️
pyirf/tests/test_binning.py 100.00% <100.00%> (ø)
pyirf/tests/test_cuts.py 98.59% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a7416...cb09ddb. Read the comment docs.

@maxnoe maxnoe merged commit 2929cd1 into master Jul 20, 2022
@maxnoe maxnoe deleted the under_over_flow branch July 20, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants