Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ang res unit handling, fixes #192 #193

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 90.86% // Head: 90.88% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a1b24da) compared to base (2929cd1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   90.86%   90.88%   +0.01%     
==========================================
  Files          41       41              
  Lines        1620     1623       +3     
==========================================
+ Hits         1472     1475       +3     
  Misses        148      148              
Impacted Files Coverage Δ
pyirf/benchmarks/angular_resolution.py 100.00% <100.00%> (ø)
pyirf/benchmarks/tests/test_angular_resolution.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxnoe maxnoe merged commit db7ed63 into master Sep 21, 2022
@maxnoe maxnoe deleted the fix_ang_res_unit_handling branch September 21, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants