New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor interpolation structure #228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iscretePDFInteprolator
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 92.46% 92.59% +0.12%
==========================================
Files 49 50 +1
Lines 2005 2120 +115
==========================================
+ Hits 1854 1963 +109
- Misses 151 157 +6
☔ View full report in Codecov by Sentry. |
maxnoe
reviewed
Jun 9, 2023
maxnoe
reviewed
Jun 9, 2023
maxnoe
reviewed
Jun 9, 2023
maxnoe
reviewed
Jun 9, 2023
maxnoe
reviewed
Jun 9, 2023
maxnoe
reviewed
Jun 9, 2023
maxnoe
reviewed
Jun 12, 2023
maxnoe
reviewed
Jun 14, 2023
maxnoe
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion in the context of #221 with @maxnoe, he asked to change the current interpolation structure in a way that has completely decoupled inter- and extrapolator classes that are instantiated by a specific estimator class for each IRF HDU. This structure also handles the data checks currently done in the interpolator classes. This removes the old
interpolate_xyz
functions (definitively a breaking change) in favor of an API with actual reusable objects and some kind of configurability.Please check carefully, if this structure is now as desired. I'll add missing documentation afterwards.