Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor interpolation structure #228

Merged
merged 14 commits into from Jun 14, 2023
Merged

Conversation

RuneDominik
Copy link
Member

After discussion in the context of #221 with @maxnoe, he asked to change the current interpolation structure in a way that has completely decoupled inter- and extrapolator classes that are instantiated by a specific estimator class for each IRF HDU. This structure also handles the data checks currently done in the interpolator classes. This removes the old interpolate_xyz functions (definitively a breaking change) in favor of an API with actual reusable objects and some kind of configurability.

Please check carefully, if this structure is now as desired. I'll add missing documentation afterwards.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 97.57% and project coverage change: +0.12 🎉

Comparison is base (c939be6) 92.46% compared to head (489e954) 92.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   92.46%   92.59%   +0.12%     
==========================================
  Files          49       50       +1     
  Lines        2005     2120     +115     
==========================================
+ Hits         1854     1963     +109     
- Misses        151      157       +6     
Impacted Files Coverage Δ
.../interpolation/tests/test_griddata_interpolator.py 100.00% <ø> (ø)
pyirf/interpolation/quantile_interpolator.py 98.14% <85.71%> (-1.86%) ⬇️
...ion/tests/test_component_estimator_base_classes.py 96.03% <96.03%> (ø)
pyirf/interpolation/component_estimators.py 98.33% <98.33%> (ø)
pyirf/interpolation/__init__.py 100.00% <100.00%> (ø)
pyirf/interpolation/base_interpolators.py 96.29% <100.00%> (-2.24%) ⬇️
pyirf/interpolation/griddata_interpolator.py 100.00% <100.00%> (ø)
...irf/interpolation/tests/test_base_interpolators.py 100.00% <100.00%> (+1.70%) ⬆️
...tests/test_component_estimator_specific_classes.py 100.00% <100.00%> (ø)
.../interpolation/tests/test_quantile_interpolator.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RuneDominik RuneDominik requested a review from maxnoe June 12, 2023 09:45
@RuneDominik RuneDominik requested a review from maxnoe June 13, 2023 14:19
@RuneDominik RuneDominik requested a review from maxnoe June 14, 2023 13:34
@maxnoe maxnoe merged commit 6c9bc6a into main Jun 14, 2023
7 of 8 checks passed
@maxnoe maxnoe deleted the RefactorInterpolationStructure branch June 14, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants