Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill n_events in angular_resolution #231

Merged
merged 1 commit into from Jul 3, 2023
Merged

Fill n_events in angular_resolution #231

merged 1 commit into from Jul 3, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 3, 2023

Fixes #230

@maxnoe maxnoe requested a review from HealthyPear as a code owner July 3, 2023 13:21
@maxnoe maxnoe requested a review from SimoneMender July 3, 2023 13:21
RuneDominik
RuneDominik previously approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@RuneDominik RuneDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit torn if this should have a bugfix changelog entry, changes look fine however

@maxnoe
Copy link
Member Author

maxnoe commented Jul 3, 2023

Definetely a bugfix changelog, will add

@maxnoe
Copy link
Member Author

maxnoe commented Jul 3, 2023

done

@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b3839f1) 93.53% compared to head (69c65b2) 93.54%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   93.53%   93.54%           
=======================================
  Files          52       52           
  Lines        2429     2432    +3     
=======================================
+ Hits         2272     2275    +3     
  Misses        157      157
Impacted Files Coverage Δ
pyirf/benchmarks/angular_resolution.py 100.00% <100.00%> (ø)
pyirf/benchmarks/tests/test_angular_resolution.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxnoe maxnoe merged commit fdccc13 into main Jul 3, 2023
7 checks passed
@maxnoe maxnoe deleted the fix_empty_n_events branch July 3, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuneDominik RuneDominik RuneDominik approved these changes

@HealthyPear HealthyPear Awaiting requested review from HealthyPear HealthyPear is a code owner

@SimoneMender SimoneMender Awaiting requested review from SimoneMender

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty column in pyirf.benchmarks.angular_resolution()
2 participants
@maxnoe @RuneDominik