Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GridDataInterpolator Testfile #235

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Correct GridDataInterpolator Testfile #235

merged 1 commit into from
Jul 4, 2023

Conversation

RuneDominik
Copy link
Member

Found some shortcomings in this test file, nothing compromising the tests however.

@RuneDominik RuneDominik added the no-changelog-needed Minor change, no newsfragment/changelog needed label Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (83ea9aa) 93.94% compared to head (41d2dd1) 93.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   93.94%   93.95%           
=======================================
  Files          54       54           
  Lines        2544     2548    +4     
=======================================
+ Hits         2390     2394    +4     
  Misses        154      154           
Impacted Files Coverage Δ
pyirf/benchmarks/angular_resolution.py 100.00% <100.00%> (ø)
pyirf/benchmarks/tests/test_angular_resolution.py 100.00% <100.00%> (ø)
.../interpolation/tests/test_griddata_interpolator.py 100.00% <100.00%> (ø)
pyirf/spectral.py 77.31% <100.00%> (+0.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RuneDominik RuneDominik changed the title Fix wording and object names, blackify Correct GridDataInterpolator Testfile Jul 4, 2023
@maxnoe maxnoe merged commit d2e2681 into main Jul 4, 2023
8 checks passed
@RuneDominik RuneDominik deleted the CorrectGridDataTests branch July 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed Minor change, no newsfragment/changelog needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants