Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower viewcone limit #239

Merged
merged 8 commits into from Aug 23, 2023
Merged

Add lower viewcone limit #239

merged 8 commits into from Aug 23, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 14, 2023

To enable computing IRFs for simulations that have also a lower viewcone limit (e.g. LST ring-wobble MCs), add this missing information here.

@maxnoe maxnoe requested a review from HealthyPear as a code owner July 14, 2023 09:57
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (1164644) 94.78% compared to head (fb8948a) 94.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   94.78%   94.82%   +0.03%     
==========================================
  Files          60       60              
  Lines        3050     3073      +23     
==========================================
+ Hits         2891     2914      +23     
  Misses        159      159              
Files Changed Coverage Δ
pyirf/irf/tests/test_effective_area.py 100.00% <ø> (ø)
pyirf/simulations.py 97.10% <100.00%> (+0.32%) ⬆️
pyirf/tests/test_simulations.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

pyirf/simulations.py Show resolved Hide resolved
pyirf/tests/test_simulations.py Outdated Show resolved Hide resolved
@maxnoe maxnoe merged commit 3fc6a0e into main Aug 23, 2023
9 checks passed
@maxnoe maxnoe deleted the viewcone_min branch August 23, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants