Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .github workflows #242

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Update .github workflows #242

merged 1 commit into from
Jul 18, 2023

Conversation

RuneDominik
Copy link
Member

This updates the workflows to the newest version and adds a test setup for python 3.11.

@RuneDominik RuneDominik added maintenance no-changelog-needed Minor change, no newsfragment/changelog needed labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (642940a) 94.33% compared to head (05a5274) 94.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files          58       58           
  Lines        2738     2738           
=======================================
  Hits         2583     2583           
  Misses        155      155           
Impacted Files Coverage Δ
.../interpolation/tests/test_griddata_interpolator.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RuneDominik RuneDominik changed the title Update .gitlab workflows Update .github workflows Jul 18, 2023
@maxnoe
Copy link
Member

maxnoe commented Jul 18, 2023

Thanks!

As per NEP-29, we can also drop 3.8 now:

On Apr 14, 2023 drop support for Python 3.8 (initially released on Oct 14, 2019)

@RuneDominik
Copy link
Member Author

Thanks!

As per NEP-29, we can also drop 3.8 now:

On Apr 14, 2023 drop support for Python 3.8 (initially released on Oct 14, 2019)

If we want this I'll make this a new PR, arguably we could wait for ctapipe to make this move as pyirf likely will become a dependency there sometime and we may want to aim for consistency throughout cta-observatory packages. However, even them requiring python >= 3.8 and us python >= 3.9 is ofc. solvable.

@RuneDominik RuneDominik merged commit 2ef3ea5 into main Jul 18, 2023
10 of 11 checks passed
@RuneDominik RuneDominik deleted the update_github_ci branch July 18, 2023 10:13
@maxnoe
Copy link
Member

maxnoe commented Jul 18, 2023

The PR for this in ctapipe is already open. But that's kind of besides the point. The consistency here is via NEP 29, as soon as we make a new non-bugfix release, we drop versions accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance no-changelog-needed Minor change, no newsfragment/changelog needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants