Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start working on fixing interpolation for fixed edisp #251

Merged
merged 10 commits into from Aug 22, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Aug 21, 2023

@RuneDominik This is a PR targeting #250 with changes related to the interpolation code.

I started this during ICRC and will have a look now again, I don't remember quite how far I got, please have a look and maybe just push here any changes you might want to include to make it work

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 99.31% and project coverage change: +0.02% 🎉

Comparison is base (8275a43) 94.74% compared to head (f4a929c) 94.76%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           fix_edisp_normalization     #251      +/-   ##
===========================================================
+ Coverage                    94.74%   94.76%   +0.02%     
===========================================================
  Files                           60       60              
  Lines                         2985     3040      +55     
===========================================================
+ Hits                          2828     2881      +53     
- Misses                         157      159       +2     
Files Changed Coverage Δ
pyirf/interpolation/component_estimators.py 99.27% <92.85%> (-0.73%) ⬇️
pyirf/interpolation/base_interpolators.py 95.00% <94.11%> (-1.30%) ⬇️
pyirf/interpolation/base_extrapolators.py 100.00% <100.00%> (ø)
pyirf/interpolation/moment_morph_interpolator.py 100.00% <100.00%> (ø)
pyirf/interpolation/nearest_neighbor_searcher.py 100.00% <100.00%> (ø)
...yirf/interpolation/nearest_simplex_extrapolator.py 100.00% <100.00%> (ø)
pyirf/interpolation/quantile_interpolator.py 98.21% <100.00%> (+0.06%) ⬆️
...irf/interpolation/tests/test_base_extrapolators.py 100.00% <100.00%> (ø)
...irf/interpolation/tests/test_base_interpolators.py 100.00% <100.00%> (ø)
...ion/tests/test_component_estimator_base_classes.py 96.69% <100.00%> (+0.16%) ⬆️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe added the no-changelog-needed Minor change, no newsfragment/changelog needed label Aug 22, 2023
@maxnoe
Copy link
Member Author

maxnoe commented Aug 22, 2023

Going on in #250

@maxnoe maxnoe merged commit 2dd65fe into fix_edisp_normalization Aug 22, 2023
8 of 9 checks passed
@maxnoe maxnoe deleted the fixed_edisp_interpolation branch August 22, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed Minor change, no newsfragment/changelog needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants