Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore warnings of possibly NaN bins in sensitivity #264

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

Tobychev
Copy link
Contributor

By putting the multiplications with rel_sens into a errstate context manager that ignores warnings from the invalid floating point operations the NaNs in rel_sens cause.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@d8de7a4). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage        ?   95.35%           
=======================================
  Files           ?       60           
  Lines           ?     3097           
  Branches        ?        0           
=======================================
  Hits            ?     2953           
  Misses          ?      144           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tobychev
Copy link
Contributor Author

@maxnoe I have no idea why, but I think something has broken the doctests.

@maxnoe
Copy link
Member

maxnoe commented Sep 26, 2023

Seems to just be a download failure, I restarted the docs build

@Tobychev
Copy link
Contributor Author

The problem seems to be pretty enduring.

@maxnoe
Copy link
Member

maxnoe commented Sep 27, 2023

Should be fixed now... let's try again

@Tobychev Tobychev merged commit dbacc33 into main Sep 29, 2023
8 of 9 checks passed
@maxnoe maxnoe deleted the no_nan_annoyance branch September 29, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants