Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table based on DAMPE results #278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VictorBarbosaMartins
Copy link

Hello.

I updated the table with the DAMPE (still preliminary) results from 2021: https://inspirehep.net/files/f08b6bbb9cade07c5c11b8d3f16e9493

In the paper, the data are given in m^-2 sr^-1 s^-1 GeV ^1.7 but I converted to m^-2 sr^-1 s^-1 GeV ^-1 as the old data (see comparison plot below):

image

If you check both publications, the new results cover now up to 10^5 GeV.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (273afd6) 95.40% compared to head (bce5e79) 95.40%.

❗ Current head bce5e79 differs from pull request most recent head 8f73bd9. Consider uploading reports for the commit 8f73bd9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          60       60           
  Lines        3135     3135           
=======================================
  Hits         2991     2991           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe
Copy link
Member

maxnoe commented Jan 19, 2024

Hi @VictorBarbosaMartins

I'd prefer not to update the table, since it was used and is based on a specific publcation, but rather to add new tables for the new references.

If I understood correctly, these are also separate tables for Protons and Helium, so it would be nice to have them, people can just add the resulting spectra if they want to have the combined flux.

@maxnoe
Copy link
Member

maxnoe commented Jan 19, 2024

Ah sorry, this is indeed the same P +He spectrum, just ICRC 2019 vs. 2021. Still, I think we should have both tables and maybe call them accordingly.

@maxnoe
Copy link
Member

maxnoe commented Jan 19, 2024

I thought there were publications by know giving the individual fluxes.

@VictorBarbosaMartins
Copy link
Author

Hi @maxnoe. I returned the file to its previous state and created a new one with the 2021 data points as suggested. I think it would have been better to link the publication to a specific version of the package via e.g. a zenodo doi instead of not updating the data. But I am also not used to this package and do not know how important this actually is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants