Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add energy dispersion unit test #41

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Add energy dispersion unit test #41

merged 4 commits into from
Sep 25, 2020

Conversation

LukasNickel
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #41 into rewrite will increase coverage by 3.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           rewrite      #41      +/-   ##
===========================================
+ Coverage    45.65%   49.58%   +3.93%     
===========================================
  Files           25       26       +1     
  Lines          587      609      +22     
===========================================
+ Hits           268      302      +34     
+ Misses         319      307      -12     
Impacted Files Coverage Δ
pyirf/irf/tests/test_energy_dispersion.py 100.00% <100.00%> (ø)
pyirf/irf/energy_dispersion.py 100.00% <0.00%> (+70.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8d8c6...bde866f. Read the comment docs.

@HealthyPear
Copy link
Member

For the joy of @maxnoe

Warning, treated as error:
/home/travis/build/cta-observatory/pyirf/docs/changelog.rst:37:Title underline too short.

`0.1.0 <https://github.com/cta-observatory/pyirf/releases/tag/v0.1.0>`__ (2020-09-16)
-----

Error: Error building sphinx doc

@maxnoe
Copy link
Member

maxnoe commented Sep 25, 2020

Working on it 🤣

@HealthyPear
Copy link
Member

Requirements

@maxnoe
Copy link
Member

maxnoe commented Sep 25, 2020

@HealthyPear This PR targets #36, so merging this will update #36, not the master branch

@HealthyPear
Copy link
Member

@HealthyPear This PR targets #36, so merging this will update #36, not the master branch

Ah sorry I didn't realize it!

Copy link
Member

@maxnoe maxnoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LukasNickel

Maintenance and computing performance automation moved this from In progress to Reviewer approved Sep 25, 2020
@maxnoe maxnoe merged commit 8482796 into rewrite Sep 25, 2020
Maintenance and computing performance automation moved this from Reviewer approved to Done Sep 25, 2020
@maxnoe maxnoe deleted the rewrite_unit_tests branch September 25, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants