Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI deploy and metadata #46

Merged
merged 2 commits into from Sep 28, 2020
Merged

Add PyPI deploy and metadata #46

merged 2 commits into from Sep 28, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 27, 2020

No description provided.

@HealthyPear HealthyPear linked an issue Sep 27, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   72.12%   72.12%           
=======================================
  Files          29       29           
  Lines         696      696           
=======================================
  Hits          502      502           
  Misses        194      194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cec78...a5f5b37. Read the comment docs.

HealthyPear
HealthyPear previously approved these changes Sep 27, 2020
@HealthyPear HealthyPear moved this from In progress to Review in progress in Maintenance and computing performance Sep 27, 2020
@HealthyPear HealthyPear moved this from Review in progress to Reviewer approved in Maintenance and computing performance Sep 27, 2020
setup.cfg Outdated
@@ -1,12 +1,30 @@
[metadata]
name = pyirf
description = Python IACT IRF builder,
description = A python library to calculate IACT IRFs and Sensitivities
url = https://github.com/cta-observatory/pyirf
author = CTA Consortium, Analysis and Simulation Working Group
author_email = thomas.vuillaume@lapp.in2p3.fr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can sure be the contact person if there is no other email but I think we may change that as well 😅
aswg email?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups! I didn't see that...as far as I know we are allowed only 1 email here, right?
In that case the aswg one could be a good choice

though, I don't think I would ever email the author for a problem, I would go to the repo...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the aswg mailing list writable to for non-members? If yes, It would probably be a good choice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea...perhaps @bregeon knows

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-members, emails are forwarded to the list moderators, i.e. the list owners, i.e. the ASWG coordinators.
Eventually, this package will be owned and maintained by CTAO (or related to), so the contact person shall be either CTAO User Support or the "official" contact working as IkC for CTAO.

I am not sure what the best temporary solution is, we shall discuss with CTAO Computing if they have a preference.
Let see if we can come up with some agreement today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add me or michele for now until there is a more official one

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxnoe yes, sounds good.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For information, I have opened the issue with official instances, not only for pyIRF.

Maintenance and computing performance automation moved this from Reviewer approved to Review in progress Sep 28, 2020
Maintenance and computing performance automation moved this from Review in progress to Reviewer approved Sep 28, 2020
@maxnoe maxnoe merged commit 135fa1f into master Sep 28, 2020
Maintenance and computing performance automation moved this from Reviewer approved to Done Sep 28, 2020
@maxnoe maxnoe deleted the travis branch September 28, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Upload to pypi
5 participants