Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify hdus using ogadf-schema #63

Merged
merged 6 commits into from Sep 29, 2020
Merged

Verify hdus using ogadf-schema #63

merged 6 commits into from Sep 29, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 28, 2020

This adds tests verifying that the hdus created by pyirf.io.gadf are schema compliant to the GADF schemas using ogadf-schema

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #63 into master will increase coverage by 2.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   74.03%   76.27%   +2.24%     
==========================================
  Files          31       31              
  Lines         751      784      +33     
==========================================
+ Hits          556      598      +42     
+ Misses        195      186       -9     
Impacted Files Coverage Δ
pyirf/io/tests/test_gadf.py 98.94% <100.00%> (+0.56%) ⬆️
pyirf/io/gadf.py 98.68% <0.00%> (+11.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e2a24...24912f8. Read the comment docs.

Copy link
Member

@vuillaut vuillaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - shall we merge?

@maxnoe
Copy link
Member Author

maxnoe commented Sep 29, 2020

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants