Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method integrating sim. events in FOV bins #67

Merged
merged 4 commits into from Sep 29, 2020
Merged

Add method integrating sim. events in FOV bins #67

merged 4 commits into from Sep 29, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 29, 2020

Fixes #51

@maxnoe @vuillaut
Add method integrating sim. events in FOV bins
f5ffd08 
Co-authored-by: Michele Peresano <michele.peresano@cea.fr>
Co-authored-by: Thomas Villaume <thomas.vuillaume@lapp.in2p3.fr>
Co-authored-by: Léa Jouvin <lea.jouvin@apc.in2p3.fr>
@codecov
Copy link

codecov bot commented Sep 29, 2020 •
edited

Codecov Report

Merging #67 into master will increase coverage by 2.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   76.27%   78.37%   +2.09%     
==========================================
  Files          31       32       +1     
  Lines         784      860      +76     
==========================================
+ Hits          598      674      +76     
  Misses        186      186
Impacted Files Coverage Δ
pyirf/irf/effective_area.py 100.00% <100.00%> (ø)
pyirf/simulations.py 96.55% <100.00%> (+4.88%) ⬆️
pyirf/tests/test_simulations.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc826fa...cbf2f07. Read the comment docs.

vuillaut
vuillaut previously approved these changes Sep 29, 2020
View reviewed changes
@maxnoe maxnoe mentioned this pull request Sep 29, 2020
Merged
@maxnoe
Copy link
Member Author

maxnoe commented Sep 29, 2020

Sorry, @vuillaut had to push again, please reapprove.

@maxnoe maxnoe merged commit e406cbe into master Sep 29, 2020
@maxnoe maxnoe deleted the integrate_sim_events branch September 29, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuillaut vuillaut vuillaut approved these changes

@HealthyPear HealthyPear Awaiting requested review from HealthyPear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

histogram of simulated events(direction)
2 participants
@maxnoe @vuillaut