Change argument order in create_rad_max_hdu #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make rad_max the first argument for consistency within the io module - Remove print statement from unit test
maxnoe
approved these changes
Sep 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 78.81% 78.79% -0.03%
==========================================
Files 32 32
Lines 878 877 -1
==========================================
- Hits 692 691 -1
Misses 186 186
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor inconsistency in the call of
create_rad_max_hdu.See #57