Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration of power law pdf in simulations.py #79

Merged
merged 2 commits into from Oct 1, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Sep 30, 2020

By accident, it was working before as the simulated index is -2 so we only had a sign error that canceled with a second sign error.

Co-authored-by Maximilian Nöthe <maximilian.noethe@tu-dortmund.de>
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files          33       33           
  Lines         904      904           
=======================================
  Hits          731      731           
  Misses        173      173           
Impacted Files Coverage Δ
pyirf/simulations.py 96.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1224aca...5bb9e0d. Read the comment docs.

@maxnoe maxnoe added the bug Something isn't working label Oct 1, 2020
@maxnoe maxnoe merged commit 7e123d9 into master Oct 1, 2020
@maxnoe maxnoe deleted the fix_energy_integral branch October 1, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants