New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lthyPear/pyrf into feature-add_integration_test
HealthyPear
added this to In progress
in Maintenance and computing performance
via automation
Oct 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 87.17% 87.50% +0.32%
==========================================
Files 35 36 +1
Lines 1138 1168 +30
==========================================
+ Hits 992 1022 +30
Misses 146 146
Continue to review full report at Codecov.
|
maxnoe
reviewed
Oct 2, 2020
maxnoe
previously approved these changes
Oct 2, 2020
Maintenance and computing performance
automation
moved this from In progress
to Reviewer approved
Oct 2, 2020
Maintenance and computing performance
automation
moved this from Reviewer approved
to Review in progress
Oct 2, 2020
Maintenance and computing performance
automation
moved this from Review in progress
to Reviewer approved
Oct 2, 2020
maxnoe
previously approved these changes
Oct 2, 2020
Maintenance and computing performance
automation
moved this from Reviewer approved
to Review in progress
Oct 2, 2020
maxnoe
approved these changes
Oct 2, 2020
Maintenance and computing performance
automation
moved this from Review in progress
to Reviewer approved
Oct 2, 2020
Maintenance and computing performance
automation
moved this from Reviewer approved
to Done
Oct 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test that runs the EventDisplay example.
It is part of issue #24.
Travis now runs the example from this test which:
Note
This test operates on the current test data which corresponds to the on-axis case.
Once we'll set up the off-axis DL2 test data to download, we'll need a new script (even by copying the current one).
That script will require its own integration test, so we should have in the end and integration test for point-like IRFs and one for full-enclosure ones.