Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test #96

Merged
merged 19 commits into from Oct 2, 2020
Merged

Add integration test #96

merged 19 commits into from Oct 2, 2020

Conversation

HealthyPear
Copy link
Member

This PR adds an integration test that runs the EventDisplay example.

It is part of issue #24.

Travis now runs the example from this test which:

Note
This test operates on the current test data which corresponds to the on-axis case.
Once we'll set up the off-axis DL2 test data to download, we'll need a new script (even by copying the current one).
That script will require its own integration test, so we should have in the end and integration test for point-like IRFs and one for full-enclosure ones.

@HealthyPear HealthyPear added this to In progress in Maintenance and computing performance via automation Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #96 into master will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   87.17%   87.50%   +0.32%     
==========================================
  Files          35       36       +1     
  Lines        1138     1168      +30     
==========================================
+ Hits          992     1022      +30     
  Misses        146      146              
Impacted Files Coverage Δ
pyirf/io/tests/test_gadf.py 98.88% <ø> (-0.05%) ⬇️
pyirf/io/gadf.py 100.00% <100.00%> (ø)
pyirf/tests/test_eventdisplay_comparison.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64bb3aa...decbf14. Read the comment docs.

maxnoe
maxnoe previously approved these changes Oct 2, 2020
Maintenance and computing performance automation moved this from In progress to Reviewer approved Oct 2, 2020
Maintenance and computing performance automation moved this from Reviewer approved to Review in progress Oct 2, 2020
Maintenance and computing performance automation moved this from Review in progress to Reviewer approved Oct 2, 2020
maxnoe
maxnoe previously approved these changes Oct 2, 2020
Maintenance and computing performance automation moved this from Reviewer approved to Review in progress Oct 2, 2020
Maintenance and computing performance automation moved this from Review in progress to Reviewer approved Oct 2, 2020
@maxnoe maxnoe merged commit 0a0c296 into master Oct 2, 2020
Maintenance and computing performance automation moved this from Reviewer approved to Done Oct 2, 2020
@maxnoe maxnoe deleted the feature-add_integration_test branch October 2, 2020 16:04
@HealthyPear HealthyPear mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants