Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store correct signal amount, store information on which checks failed for sensitivity bins #97

Merged
merged 5 commits into from Oct 5, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 2, 2020

This just adds a column on which of the 3 checks failed to the output

@maxnoe maxnoe changed the title Store information on which checks failed for sensitivity bins Store correct signal amount, store information on which checks failed for sensitivity bins Oct 2, 2020
@maxnoe maxnoe linked an issue Oct 2, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #97 into master will increase coverage by 2.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   87.08%   89.72%   +2.64%     
==========================================
  Files          35       36       +1     
  Lines        1138     1256     +118     
==========================================
+ Hits          991     1127     +136     
+ Misses        147      129      -18     
Impacted Files Coverage Δ
pyirf/sensitivity.py 91.52% <100.00%> (+24.28%) ⬆️
pyirf/tests/test_sensitivity.py 100.00% <100.00%> (ø)
pyirf/tests/test_eventdisplay_comparison.py 100.00% <0.00%> (ø)
pyirf/io/tests/test_gadf.py 99.16% <0.00%> (+0.23%) ⬆️
pyirf/io/gadf.py 100.00% <0.00%> (+1.31%) ⬆️
pyirf/utils.py 85.29% <0.00%> (+8.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5341453...c33d6ff. Read the comment docs.

examples/calculate_eventdisplay_sensitivity_cut2.py Outdated Show resolved Hide resolved
examples/calculate_eventdisplay_sensitivity_cut2.py Outdated Show resolved Hide resolved
examples/calculate_eventdisplay_sensitivity_cut2.py Outdated Show resolved Hide resolved
pyirf/tests/test_sensitivity.py Show resolved Hide resolved
@HealthyPear HealthyPear merged commit 98c044f into master Oct 5, 2020
@maxnoe maxnoe deleted the store_checks branch October 5, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store expected number of signal events in sensitivity
2 participants