Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version of Fantomas 2.8.1 used by this has a regression where formatting only by AST (no source) fails #11

Closed
7sharp9 opened this issue Oct 11, 2018 · 3 comments · Fixed by #12
Closed

Version of Fantomas 2.8.1 used by this has a regression where formatting only by AST (no source) fails #11

7sharp9 opened this issue Oct 11, 2018 · 3 comments · Fixed by #12
Milestone
0.1.1

Comments

@7sharp9
Copy link
Contributor

7sharp9 commented Oct 11, 2018

Im wondering is the dependency on Fantomas is needed as the usage of Fantomas is a paper thin wrapper really.
@ctaggart
Copy link
Contributor

Probably not. Accepting PRs to remove it

@7sharp9
Copy link
Contributor Author

7sharp9 commented Oct 11, 2018

Yeah I know you didn't really want to maintain this and I resurrected it, I dont mind removing it and cleaning some other stuff when I get a bit of time :-)

@ctaggart ctaggart added this to the 0.1.1 milestone Oct 17, 2018
@ctaggart ctaggart mentioned this issue Oct 17, 2018
Merged
@ctaggart
Copy link
Contributor

@7sharp9 https://www.nuget.org/packages/FsAst/0.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

update to fantomas 2.9.0 ionide/FsAst
2 participants
@ctaggart @7sharp9