Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving locale dir #720

Closed
jw3 opened this issue Dec 23, 2022 · 1 comment · Fixed by #733
Closed

Consider moving locale dir #720

jw3 opened this issue Dec 23, 2022 · 1 comment · Fixed by #733
Labels
Python ui Work related to the UI

Comments

@jw3
Copy link
Member

jw3 commented Dec 23, 2022

Move to root dir and rename, from fapolicy_analyzer/locale to po.

Have not investigated the implications.

@jw3 jw3 added Python ui Work related to the UI labels Dec 23, 2022
@jw3
Copy link
Member Author

jw3 commented Dec 29, 2022

There is also this warning from the rawhide build

/usr/lib/python3.11/site-packages/setuptools/command/build_py.py:153: SetuptoolsDeprecationWarning:     Installing 'fapolicy_analyzer.locale.es.LC_MESSAGES' as data is deprecated, please list it in `packages`.
    !!


    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'fapolicy_analyzer.locale.es.LC_MESSAGES' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'fapolicy_analyzer.locale.es.LC_MESSAGES' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'fapolicy_analyzer.locale.es.LC_MESSAGES' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.


!!

@jw3 jw3 closed this as completed in #733 Jan 10, 2023
jw3 added a commit that referenced this issue Jan 10, 2023
The application locales were not being included in the RPM. This PR
rearranges the location of locales, bringing them up to a top level
directory, and fixes up the installation process.

Adds additional content to the man page and fixes an issue installing it
#200.

This also fixes up a few annoyances caused from the vendoring refactor
in #730.

Also adds a check stage to CI that performs a RPM install and displays
the rpmdb metadata for it.

More #715
Closes #720
jw3 added a commit that referenced this issue Jan 10, 2023
The application locales were not being included in the RPM. This PR
rearranges the location of locales, bringing them up to a top level
directory, and fixes up the installation process.

Adds additional content to the man page and fixes an issue installing it
#200.

This also fixes up a few annoyances caused from the vendoring refactor
in #730.

Also adds a check stage to CI that performs a RPM install and displays
the rpmdb metadata for it.

More #715
Closes #720
# Conflicts:
#	.copr/Makefile
#	Makefile
#	fapolicy-analyzer.spec
#	scripts/srpm/fapolicy-analyzer.spec
jw3 added a commit that referenced this issue Jan 10, 2023
The application locales were not being included in the RPM. This PR
rearranges the location of locales, bringing them up to a top level
directory, and fixes up the installation process.

Adds additional content to the man page and fixes an issue installing it
#200.

This also fixes up a few annoyances caused from the vendoring refactor
in #730.

Also adds a check stage to CI that performs a RPM install and displays
the rpmdb metadata for it.

More #715
Closes #720
# Conflicts:
#	.copr/Makefile
#	Makefile
#	fapolicy-analyzer.spec
#	scripts/srpm/fapolicy-analyzer.spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python ui Work related to the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant