Fix for overwriting browser hotkeys with numbers (Ctrl, Alt, Cmd + Number) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehanig
changed the title
mehanig
changed the title
mehanig
added a commit
to StepicOrg/videojs-hotkeys
that referenced
this pull request
Oct 4, 2016
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Problem: While focus is on player, Numbers [0..9] react as expected - rewinds player to specific % of video. But, if
Command + Number,Ctrl + NumberorAlt + Numberis pressed, player behaves same. This combination is usually set to browsersSelect Tab Hotkey( Go to Nth Tab )Solution: I realize, that someone would like this behavior, and for backwards compatibility, this logic should stay as default. But, if it's unexpected, let's give an option to react only if Number is pressed without modifiers. This is done by adding new default option -
enableModifiersForNumbers