Catch OS errors when loading private key and certificate files. (e.g.… (

#128) * Catch OS errors when loading private key and certificate files. (e.g. Path too long) * Add is_enabled method to edge/snmp module
ctera · Jul 6, 2021 · e5b333c · e5b333c
1 parent 3ac1937
commit e5b333c
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/cterasdk/edge/snmp.py b/cterasdk/edge/snmp.py
@@ -9,6 +9,15 @@
 class SNMP(BaseCommand):
     """ Edge Filer SNMP Configuration APIs """
 
+    def is_enabled(self):
+        """
+        Check if SNMP is enabled
+
+        :return: True is SNMP is enabled, else False
+        :rtype: bool
+        """
+        return self._gateway.get('/config/snmp/mode') == enum.Mode.Enabled
+
     def enable(self, port=161, community_str=None, username=None, password=None):
         """
         Enable SNMP

diff --git a/cterasdk/lib/crypto.py b/cterasdk/lib/crypto.py
@@ -100,7 +100,7 @@ def load_private_key(key, password=None):
         try:
             FileSystem.instance().get_local_file_info(key)
             return PrivateKey.from_file(key, password)
-        except LocalFileNotFound:
+        except (OSError, LocalFileNotFound):
             return PrivateKey.from_string(key, password)
 
 
@@ -156,7 +156,7 @@ def load_certificate(cert):
         try:
             FileSystem.instance().get_local_file_info(cert)
             return X509Certificate.from_file(cert)
-        except LocalFileNotFound:
+        except (OSError, LocalFileNotFound):
             return X509Certificate.from_string(cert)
 
     def __str__(self):

diff --git a/docs/source/user_guides/Gateway/Gateway.rst b/docs/source/user_guides/Gateway/Gateway.rst
@@ -1122,6 +1122,13 @@ Power Management
 SNMP
 ====
 
+.. automethod:: cterasdk.edge.snmp.SNMP.is_enabled
+   :noindex:
+
+.. code-block:: python
+
+   filer.snmp.is_enabled()
+
 .. automethod:: cterasdk.edge.snmp.SNMP.enable
    :noindex: