Fix image transform on Windows server by forcing temporary path #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This issue seems to occur when running PHP on a Windows server.
This pull requests fixes #52, fixes #72, fixes #92, fixes #100, fixes #101
Error
Intervention throws
Encoding format (tmp) is not supported.
This happens because the package uses the Laravel's UploadedFile directly when doing the crop/resize transformation. It tries to save it after the transformation and before passing it onto Laravel for final storage. But at this point, the UploadedFile is still in a temp folder.
On Windows, it seems that Intervention struggles to determine the file's extension and uses
tmp
, which fails.Solution
Forcing the extension using the one from the UploadedFile seems to work.
This pull requests therefore provides parameters to the Intervention's
save
method to specify the full path (even though it's still the temp one) and most importantly, the extension.