Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image transform on Windows server by forcing temporary path #102

Merged
merged 1 commit into from Mar 8, 2023

Conversation

ctessier
Copy link
Owner

@ctessier ctessier commented Mar 8, 2023

Introduction

This issue seems to occur when running PHP on a Windows server.
This pull requests fixes #52, fixes #72, fixes #92, fixes #100, fixes #101

Error

Intervention throws Encoding format (tmp) is not supported.
This happens because the package uses the Laravel's UploadedFile directly when doing the crop/resize transformation. It tries to save it after the transformation and before passing it onto Laravel for final storage. But at this point, the UploadedFile is still in a temp folder.
On Windows, it seems that Intervention struggles to determine the file's extension and uses tmp, which fails.

Solution

Forcing the extension using the one from the UploadedFile seems to work.
This pull requests therefore provides parameters to the Intervention's save method to specify the full path (even though it's still the temp one) and most importantly, the extension.

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctessier ctessier merged commit 310d851 into 2.x Mar 8, 2023
@ctessier ctessier deleted the fix-unsupported-format-windows branch March 8, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant