Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No JS or JSON icons #3

Closed
darylldoyle opened this issue Aug 25, 2014 · 9 comments
Closed

No JS or JSON icons #3

darylldoyle opened this issue Aug 25, 2014 · 9 comments

Comments

@darylldoyle
Copy link

Not sure if this is a limitation of ST3 but I don't get any icons for JS or JSON files!

screen shot 2014-08-25 at 21 05 47

@darylldoyle darylldoyle changed the title No JS or JSON icon No JS or JSON icons Aug 25, 2014
@ctf0
Copy link
Owner

ctf0 commented Aug 25, 2014

the icons + the tmPreferences files are already included ,i tried with several other themes but sadly with the same result , plz check the tmPreferences files maybe you can find a better string for the scope ,am sorry but my knowledge is limited in that area and the ST forum doesn't have much info about that :(.

@darylldoyle
Copy link
Author

No worries! I'll have a play and make a PR if I manage to sort something!

@ctf0
Copy link
Owner

ctf0 commented Aug 25, 2014

u wont believe how missed up ST is ,js is now fixed ,if u found a fix for json or (less,sass,scss) because for now ST treats all the above as css plz make a PR ,again ST is a crazy mutha*.

@darylldoyle
Copy link
Author

Haha just got JSON and JS sorted. Will make PR

@darylldoyle
Copy link
Author

Just cloned the repo and still have no JSON icons.

screen shot 2014-08-25 at 23 29 21

@ctf0
Copy link
Owner

ctf0 commented Aug 26, 2014

i just updated the screenshot ,its working fine on my behalf ,i even removed the one i already have and installed the one from this repo and no probs ,all the icons is there.

also about the js & json ,making a (icon.tmPreferences) file is useless because ST ignores it and it looks for a icon_type_js & icon_type_settings instead ,so thats what i did and the default icon also has changed to the "cog-well" so it covers the hidden one files aswell ,still i didn't remove (hidden.tmPreferences) maybe someone could come up with a solution for the hidden folders.

@ctf0 ctf0 reopened this Aug 26, 2014
@darylldoyle
Copy link
Author

OK, will run some more tests when I get home this evening.

Cloned this repo at work this morning and had the same issues, also had no find in project icons which was odd, had to manually find and replace the old theme name out again.

@ctf0
Copy link
Owner

ctf0 commented Aug 26, 2014

@darylldoyle that god dam old theme name is now fixed for good ,am terribly sorry for that.

btw ,there is a slight drop shadow under the tabset area ,do u know how to remove that ?

This was referenced Aug 26, 2014
@ctf0
Copy link
Owner

ctf0 commented Aug 26, 2014

i believe this issue is solved now so will close it.

@ctf0 ctf0 closed this as completed Aug 26, 2014
ctf0 pushed a commit that referenced this issue Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants