Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when filename or path contains multi-byte characters #251

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

warbaby
Copy link
Contributor

@warbaby warbaby commented Aug 29, 2018

In multi-byte utf-8 string, the "string.length" is not equal to buffer bytes length.
Zipping a file or directory with multi-byte character in the name will corrupt the zip file.

@cthackers cthackers merged commit aec5998 into cthackers:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants