Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up bundle reveal type settings #31

Closed
ctjdr opened this issue Jan 3, 2021 · 0 comments · Fixed by #42
Closed

Clean up bundle reveal type settings #31

ctjdr opened this issue Jan 3, 2021 · 0 comments · Fixed by #42
Assignees
@ctjdr
Labels
enhancement New feature or request
Projects
The Board
Milestone
v0.3.0

Comments

@ctjdr
Copy link
Owner

ctjdr commented Jan 3, 2021

Currently there are two properties to control the "Open bundle" behaviour:

  • apprtbundles.bundles.reveal.goal.type
  • apprtbundles.bundles.reveal.goal.expandFolder

The latter one should be removed and become an additional option in the first one, so that it has folder, manifest, and folderExpand.

There is no migration, as we are currently on a 0.x unstable release.
The changelog and 0.3.0 release notes should get an according note about the change however.
@ctjdr ctjdr added the enhancement New feature or request label Jan 3, 2021
@ctjdr ctjdr self-assigned this Jan 3, 2021
@ctjdr ctjdr added this to the v0.3.0 milestone Jan 3, 2021
@ctjdr ctjdr added this to In progress in The Board Jan 3, 2021
@ctjdr ctjdr moved this from In progress to To do in The Board Jan 3, 2021
@ctjdr ctjdr moved this from To do to In progress in The Board Jan 7, 2021
ctjdr added a commit that referenced this issue Jan 7, 2021
@ctjdr
#31 - Remove unnec config elem
630fee7
ctjdr added a commit that referenced this issue Jan 7, 2021
@ctjdr
#31 - Support migrate "expandFolder" toggle to "folderExpand" option
a24b639
ctjdr added a commit that referenced this issue Jan 7, 2021
@ctjdr
#31 - Support migrate "expandFolder" toggle to "folderExpand" option (#…
2574f73 
…42)
@ctjdr ctjdr linked a pull request Jan 7, 2021 that will close this issue
#31 - Migrate "expandFolder" toggle to "folderExpand" option #42
Merged
@ctjdr ctjdr moved this from In progress to Done in The Board Jan 7, 2021
@ctjdr ctjdr closed this as completed Jan 7, 2021
@ctjdr ctjdr moved this from Done to Rolled out in The Board Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctjdr ctjdr

Labels
enhancement New feature or request
Projects
The Board
Rolled out
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

#31 - Migrate "expandFolder" toggle to "folderExpand" option ctjdr/vscode-apprt-bundles
1 participant
@ctjdr